search

jmbowman1107 / ImageCropper.Maui

MIT License
56 stars 13 forks source link

net 8 update + fix ios build issues #20

Closed PavloLukianets closed 7 months ago

PavloLukianets commented 7 months ago

fixes #19 fixes #16 fixes #11

Everything that is left for u to do is to build the new nugets

jmbowman1107 commented 7 months ago

Thank you for this! I tried and pushed out a new version with this, v1.1.0.1. I no longer work for the company I did when I started this, so I don't have a Mac to test this to validate it was successful. Please try it and let me know.

themronion commented 7 months ago

It is me, pr author, from personal account. I am using only the iOS binding, so i tested only it, works fine. Most likely the MAUI version works fine too, we will know that for sure by the amount of new issues in the repo, if any :) P.S. I think this commit is redundant - https://github.com/jbowmanp1107/ImageCropper.Maui/commit/82dcedbef059d1997d9e34f9f2dc42edc4fd68de# Did u add it because you were using Hot Restart on Windows and not all needed files were in the nuget?

jmbowman1107 commented 7 months ago

Hi, thanks again! I think you are right in that it is redundant.. The NuGet package didn't seem to install correctly when installing from Visual Studio on Windows, and when I inspected the installed package these files were missing.. however.. they were actually in the actual nuget package.. Turned out the issue was the file lengths in this package get so long.. and go over the 260 character limit that windows supports by default, that during package install there is an error.. and a lot files are not installed from the package.

I think one issue that will pop up will be that! To fix it, anyone can use 'dotnet restore' from the CLI, and it gets around this limitation.. but installing the package from within Visual Studio on Windows is actually broken because of the file lengths..