jmbuhr / ShinyLipids

Interactive data exploration for lipidomics
https://jmbuhr.de/ShinyLipids/
Other
1 stars 3 forks source link

Plotly legend overlaps with barplot #60

Open luechtian opened 4 years ago

luechtian commented 4 years ago

image

Next zoomlevel looks like this: image

Furthermore the contours of the individuals are very bold, right? Could you change that? The overall appearance of the ggplots looked better, in my opinion. Maybe it is a trade off we have to deal with. What is your opinion on that?

jmbuhr commented 4 years ago

I agree. This is why I definitely want to keep the underlying ggplot for the download buttons. The ggplot object gets passed to plotly::ggplotly() to convert it to a plotly plot (with it's own drawbacks, see previous commits where I had to change the ggplot) and then rendered. I previously played around with passing the plotly plot through some plotly layout functions but wasn't happy with the result so far, see the removed code in: https://github.com/jmbuhr/ShinyLipids/commit/232b9decdf4ed11e0be44a41e9d0be68a289d2b9. The plotly plot is also not very manageable with smaller window sizes. If you are up for the challenge, you could clone the repo, experiment around with the plotly layout parameters and create a pull request. This would be really cool!

luechtian commented 4 years ago

Sure, why not :D I will dig in to this!