jmcarp / betfair.py

A Python wrapper for the Betfair API
MIT License
103 stars 76 forks source link

Logging #34

Closed aa403 closed 6 years ago

aa403 commented 9 years ago

improved logging support form my other PR and moved onto dedicated branch (interactive login issues need to be handled separately)

goetzk commented 9 years ago

I've just pulled this down to try it out (thanks for working on it by the way). I have a few comments/suggestions:

Hopefully in the next few days I'll find some time to try it out and see if/how it can be configured to vary the logging output.

ms5 commented 9 years ago

I think logging should not be part of the API but of the custom program code. Defining a log destination, format logs, etc is part of the application and differs a lot from system and or application. therefore i suggest to not create a logger inside the api. this can easily be created in the application. events logged with the python logger will still be available in the application logger.

especially what is done in "bf_logging.py" belongs really to the application and not the the api.