jmcarp / betfair.py

A Python wrapper for the Betfair API
MIT License
103 stars 76 forks source link

fix names in constants and models #37

Closed kwassmuss closed 9 years ago

kwassmuss commented 9 years ago

So I have created 2 patches with the most obvious fixes.

The fix in betfair/constants.py is needed if you want to use the recently introduced lean call to listMarketBook, see http://forum.bdp.betfair.com/showpost.php?p=11951&postcount=59

The others are merely fixes of names which where included in my old 'bulk' pull requests.

Note that in CurrentOrderSummary the attribute 'matched_date' is wrongly marked as required in the BF docs, but it says "when applicable" in the comment in the same docs. In fact it depends on the parameters in the API call if this attribute is returned. So marking it as required leads to an exception in parsing the response if the attribute is not there.

Note that the two patches here are created from partial commits from my working branch which also include some more ambiguous changes that I found practical (see the old issues and pull requests), so it is not tested against the API but should work nonetheless because of the nature of the fixes.