search

jmcarp / flask-apispec

MIT License
655 stars 156 forks source link

Fix duplicate serialization #161

Closed abeforgit closed 5 years ago

abeforgit commented 5 years ago

Fixes #98 As far as I can tell this is basically a typo, I can't see any case where you would want the format_response being called on data that's already been serialized by the schema.

codecov-io commented 5 years ago

Codecov Report

Merging #161 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files           8        8           
  Lines         345      345           
=======================================
  Hits          337      337           
  Misses          8        8
Impacted Files Coverage Δ
flask_apispec/wrapper.py 98.24% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b51962a...dda692d. Read the comment docs.

sloria commented 5 years ago

Thanks! Do you have time to add a test for this?

abeforgit commented 5 years ago

Will do! Give me a day or two

abeforgit commented 5 years ago

I'm less and less convinced this is a solution, I need to do some more testing to see exactly how and when the issue occurs. The workaround mentioned in #98 might actually just be the best solution for flask-restful users. I'll leave it to you whether you want to leave this PR open or close it without merging

sloria commented 5 years ago

No problem. I'll close this for now. Feel free to open a new PR if you find a better solution.