decaz commented 5 years ago

It's a quick fix which resolves #163.

@sloria I think there should be test matrix for Tox to run tests against different versions of apispec, not only marshmallow.

codecov-io commented 5 years ago

Codecov Report

Merging #164 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   97.68%   97.71%   +0.02%     
==========================================
  Files           8        8              
  Lines         346      350       +4     
==========================================
+ Hits          338      342       +4     
  Misses          8        8

Impacted Files	Coverage Δ
flask_apispec/apidoc.py	`97.26% <100%> (+0.15%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6f6c8d...190430a. Read the comment docs.

sloria commented 5 years ago

Thanks for the fix.

I think there should be test matrix for Tox to run tests against different versions of apispec, not only marshmallow.

Good idea. I don't have time to set this up myself. Would accept a PR for this.

As you can probably tell, my time to work on this project is limited, as neither I nor the original author using it for anything. I'll continue to merge and release PRs as they come in.

jmcarp / flask-apispec

Fix compatibility with apispec==3.0.0 #164

Codecov Report