jmcarp / flask-apispec

MIT License
655 stars 156 forks source link

Implemented Flask-httpauth fixes #191 #197

Closed anandtripathi5 closed 3 years ago

anandtripathi5 commented 4 years ago

@sloria @jmcarp Please check the pull request, if it makes sense then can we merge this feature.

Thanks a lot, Anand Tripathi

codecov-commenter commented 4 years ago

Codecov Report

Merging #197 (8f75c6e) into master (de6f5ad) will decrease coverage by 0.99%. The diff coverage is 100.00%.

:exclamation: Current head 8f75c6e differs from pull request most recent head 6a6f3b7. Consider uploading reports for the commit 6a6f3b7 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   97.86%   96.87%   -1.00%     
==========================================
  Files           8        8              
  Lines         375      384       +9     
==========================================
+ Hits          367      372       +5     
- Misses          8       12       +4     
Impacted Files Coverage Δ
flask_apispec/extension.py 100.00% <100.00%> (ø)
flask_apispec/apidoc.py 94.93% <0.00%> (-2.74%) :arrow_down:
flask_apispec/wrapper.py 95.83% <0.00%> (-2.72%) :arrow_down:
flask_apispec/annotations.py 90.24% <0.00%> (-0.24%) :arrow_down:
flask_apispec/paths.py 100.00% <0.00%> (ø)
flask_apispec/views.py 100.00% <0.00%> (ø)
flask_apispec/__init__.py 100.00% <0.00%> (ø)
flask_apispec/utils.py 98.27% <0.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de6f5ad...6a6f3b7. Read the comment docs.

anandtripathi5 commented 4 years ago

@jmcarp Cannot able to find how my added code, decreased the code coverage of those files. My code is not related to those files. Can you guide me?

Best, Anand Tripathi

anandtripathi5 commented 4 years ago

@sloria please check this, whenever you get time.

anandtripathi5 commented 3 years ago

Let me raise a new pull request