jmccarthy2 / id-sp17-website

Coachella website
https://jmccarthy2.github.io/id-sp17-website/index.html
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

Single-Serving Wiki To-Dos

20 to-dos, 5 points each; plus 4 extra credit to-dos

Essential

Code

30 points

Design

45 points

Optimization

5 points

Test

10 points

Git

10 points

Extra Extra

20 points

jgagne commented 7 years ago

Resolve HTML issues: https://validator.w3.org/nu/?doc=https%3A%2F%2Fjmccarthy2.github.io%2Fid-sp17-website%2Findex.html

Minor Issues

Before

  <nav>
    <summary><strong>Learn More</strong></summary>
    <ul>
      <li><a href="history.html">History</a></li>
      <li><a href="gallery.html">Gallery</a></li>
    </ul>

</nav>

Note: The <summary> element is the child of the <details> element, it cannot be used with other elements.

After

<nav>
  <h2>Learn More</h2>
  <ul>
    <li><a href="history.html">History</a></li>
    <li><a href="gallery.html">Gallery</a></li>
  </ul>
</nav>

Nesting Issues

Element p not allowed as child of element ulin this context.

Whitespace and Lowercase Issues

<section id="Impact and Legacy"> should be <section id="impact-legacy">

Please, validate all other pages and resolve any issues.

jgagne commented 7 years ago

Resolve CSS issues: http://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fjmccarthy2.github.io%2Fid-sp17-website%2Findex.html&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Minor Issues

Remove comments made with ! or properly comment out with /* this is markup for a proper comment in CSS */.

jgagne commented 7 years ago

Please, add comps folder and include a comp for this website. Thanks!

jgagne commented 7 years ago

And a meta description and reference the original source material by including <link rel="canonical" href="…"> (add url).