search

jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML
MIT License
212 stars 83 forks source link

Removed mandatory project name into reverse #24

Closed ribeiroct closed 5 years ago

ribeiroct commented 9 years ago

Is there a valid reason for the project_name being mandatory on the reverse url ?

I'm currently using this in one of my projects and i need the possibility of specifying a full path for the reverse since i don't have my paginators on my main app. Shouldn't this be default behaviour ?

Regards

ribeiroct commented 9 years ago

I have projects where i use this plugin, but i don't use it on the main application, so i have the need to make reverse's to other views. with this my reverse's had to start on the main project.

jmcclell commented 9 years ago

Ah. That makes perfect sense. Unfortunately I baked it right in so changing it isn't exactly backwards compatible. Hmm..

kvdveer commented 8 years ago

@ribeiroct I'm helping @jmcclell out by working through the merge requests now we have a proper CI.

I'm having a hard time understanding what your merge request actually tries to accomplish. In the except clause you're repeating the exact statement which already failed in the try clause. I don't see how that will fix anything - it'd just raise the same exception again (uncaught this time).