Closed miki725 closed 9 years ago
I would be surprised if installation is the only issue you run into.
I would really like to maintain backwards compatibility with 2.x if possible, as well. There are have been several other forks where people have changed things here and there, but I haven't seen someone verify that they've got it fully working under 3.x yet nor anyone who has made changes in a backwards compatible way.
I'm not against doing a major revision bump for 3.x support, though.
Have you ran into any other issues in 3.x yet?
Forgot to push another Py3 fix. Just added it. These were the two issues I came across on Py3.4 and Django1.7. Also tested on Py2.7 and did not came across any other issues.
here is by the way an example of why the second issue was breaking in Py3:
>>> list(range(1, 23/5))
Traceback (most recent call last):
File "<ipython-input-3-0dd73305fd86>", line 1, in <module>
list(range(1, 23/5))
TypeError: 'float' object cannot be interpreted as an integer
>>> list(range(1, 23//5))
[1, 2, 3]
EDIT: as for both 2.7 and 3.X compatibility, //
is valid perfectly valid in Python2 (docs) so these changes are both Py2 and Py3 compatible
I'd love to see this PR get accepted.
I didn't merge it because I thought there would be more to come for full 3.x support, but since all of these changes are fully backwards compatible to 2.7 i'll merge.
this fixes the issue while installing for Python3: