search

jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML
MIT License
212 stars 83 forks source link

Django 1.10 compatibility #44

Closed ad-m closed 8 years ago

ad-m commented 8 years ago

Hello,

I got warnings:

bootstrap_pagination/templatetags/bootstrap_pagination.py:213: RemovedInDjango110Warning: render() must be called with a dict, not a Context.

Greetings,

jmcclell commented 8 years ago

Looks like I'll need to cut a non-BC version to deal with that. Looks like it is deprecated but not yet removed?

ad-m commented 8 years ago

It's only deprecation warning. It will removed in future release (1.10). Django 1.10 wasn't released yet.

" non-BC version" What do you mean?

jmcclell commented 8 years ago

Non-backwards compatible. If render is removed, I assume it's being replaced with something that won't be present in all older versions.

kvdveer commented 8 years ago

render() is not removed, it just takes slightly different parameters. I'll submit a pull request later today.