search

jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML
MIT License
212 stars 83 forks source link

fixed context.current_app in Django 1.10 #53

Closed adilkhash closed 8 years ago

adilkhash commented 8 years ago

Hi. Fixed context.current_app AttributeError exception in Django 1.10 due to removal of current_app attribute from RequestContext object. See release notes

camilonova commented 8 years ago

@jmcclell please merge this one

beaugunderson commented 8 years ago

This PR fixes the issue I had. ✨

jmcclell commented 8 years ago

@kvdveer Thoughts? I don't have enough context at hand to know what the issue is (sorry guys, haven't been using Django for a few versions) so can't tell if this fix makes sense or not. It seems good to me..

jmduke commented 8 years ago

This also fixed the issue I had.

camilonova commented 8 years ago

@jmcclell The package does not work with latest django release without this. Please merge it and release a new version.

beaugunderson commented 8 years ago

@jmcclell i have to pitch transferring or sharing maintainership with jazzband one final time; they've been great about adding tests for multiple django versions in my experience :)