search

jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML
MIT License
212 stars 83 forks source link

Recognize Koert for his contributions as an author #55

Closed jmcclell closed 5 years ago

jmcclell commented 8 years ago

@kvdveer I'm 80% sure this syntax is kosher with pypi but haven't tested it. Perhaps as you prep the next release you can pull this in and see if it blows up in your face? :)

kvdveer commented 8 years ago

AFAIK, setuptools does not support multiple authors: http://legacy.python.org/dev/peps/pep-0345/#author-optional

You could use maintainer as a second author (which would actually be somewhat accurate), but that's not very future proof.

jmcclell commented 8 years ago

From what I understand, the "author" field is a free field. It's only author_email that is validated and must be a single, valid email address.

Author (optional)

A string containing the author's name at a minimum; additional contact information may be provided.

Example:

Author: C. Schultz, Universal Features Syndicate,
        Los Angeles, CA <cschultz@peanuts.example.com>
Author-email (optional)

A string containing the author's e-mail address. It can contain a name and e-mail address in the legal forms for a RFC-822 From: header.

Example:

Author-email: "C. Schultz" <cschultz@example.com>
kvdveer commented 8 years ago

Now that you explain it, I read it the same way. Given that it is so free form, it will probably not break anything.

On Tue, Jul 12, 2016 at 2:36 PM Jason McClellan notifications@github.com wrote:

From what I understand, the "author" field is a free field. It's only author_email that is validated and must be a single, valid email address.

Author (optional)

A string containing the author's name at a minimum; additional contact information may be provided.

Example:

Author: C. Schultz, Universal Features Syndicate, Los Angeles, CA cschultz@peanuts.example.com Author-email (optional)

A string containing the author's e-mail address. It can contain a name and e-mail address in the legal forms for a RFC-822 From: header.

Example:

Author-email: "C. Schultz" cschultz@example.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jmcclell/django-bootstrap-pagination/pull/55#issuecomment-232034168, or mute the thread https://github.com/notifications/unsubscribe/AAZmaQdgpSgjATwOL_R2fhuWzD_fMgwvks5qU4pQgaJpZM4JKUsr .

jmcclell commented 8 years ago

👍