problems with tag state when used more than once per page

jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML

MIT License

212 stars 83 forks source link

problems with tag state when used more than once per page #7

Closed fairview closed 12 years ago

fairview commented 12 years ago

In the template tag nodes' render methods, self.kwargs was being manipulated, which caused problems when using more than one pager per template context, or presumably when a tag was used by multiple concurrent threads. I noticed that when I tried to vary the url_param_name by pager instance, things were getting jumbled.

Resolving the contents of self.kwargs into a local dictionary seems to have solved this for me. Pull request on the way...

fairview commented 12 years ago

Sigh. One of these days I should actually learn how to use GitHub. Closing this in favor of #8. Sorry for the clutter.