jmcclell / django-bootstrap-pagination

Django template tag for rendering Page objects as Bootstrap pagination HTML
MIT License
212 stars 83 forks source link

Incompatible with Django 2.1 #71

Closed ScottEvansDBCA closed 5 years ago

ScottEvansDBCA commented 6 years ago

Just upgrading a project to Django 2.1 and found an error. 2.1 removes urls inline flags in the encode: url()’s support for inline flags in regular expression groups ((?i), (?L), (?m), (?s), and (?u)) is removed.

bootstrap_pagination.py line 85 url += '?' + url_get_params.urlencode() calls to django/http/request.py and gives an error: "'int' object has no attribute encode". Have commented this out and the page loads but obviously pagination no longer works.

timrichardson commented 5 years ago

fixed in this fork: https://github.com/myasui/django-bootstrap-pagination

jmcclell commented 5 years ago

I've cherry-picked. Will be in the next release.