search

jmccrohan / pysolarmanv5

A python module to interact with Solarman Data Logging Sticks
MIT License
131 stars 28 forks source link

Return the auto_reconnect as an option #36

Closed githubDante closed 1 year ago

githubDante commented 1 year ago

auto_reconnect is already marked as an optional constructor argument and should be passed to the _socket_setup function.

jmccrohan commented 1 year ago

Thanks for this. Would you mind making the corresponding change on the PySolarmanV5Async version of _socket_setup() also?

FAILED tests/test_aio_solarman.py::test_async - TypeError: PySolarmanV5Async._socket_setup() takes 2 positional arguments but 3 were given
FAILED tests/test_solarman.py::test_sync - _queue.Empty
githubDante commented 1 year ago

Fixed in the async version as well as in the test setup.

jmccrohan commented 1 year ago

@githubDante thanks, merged!