jmccrohan / pysolarmanv5

A python module to interact with Solarman Data Logging Sticks
MIT License
124 stars 27 forks source link

Fix/Feat: Error handling and disconnecting flow #61

Closed davidrapan closed 1 month ago

davidrapan commented 1 month ago

fix: Task exception was never retrieved

fix: Catch TimeoutError without logging exception

feat: Improved disconnecting flow

feat: Added serial tag to some debug messages

jmccrohan commented 1 month ago

Hi @davidrapan,

These LGTM. Would you mind making the corresponding changes on the sync version of the library (where appropriate)?

Cheers, Jon

davidrapan commented 1 month ago

Hi @githubDante and @jmccrohan,

Sure thing! I extended those debug messages also in the sync version. Added that Host unreachable catch in _send_receive_v5_frame. And disconnecting flow already had appropriate error handling.

Have fun!

jmccrohan commented 1 month ago

Merged. Thanks @davidrapan!