jmcdo29 / ogma

A monorepo for the ogma logger and related packages
https://ogma.jaymcdoniel.dev
MIT License
288 stars 36 forks source link

feat: create instrumentation package with minimal tests #1822

Closed jmcdo29 closed 1 month ago

jmcdo29 commented 1 month ago

The tests need to be re-worked significantly, originally they were written for mocha (what otel's repo uses), but I need to either re-write them for uvu or move everything ovwer to vitest as uvu's development seems to have stagnated

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 03a37fe62f70ad3092b2eb263b640adef2fe143d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @ogma/instrumentation | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11599482](https://dashboard.gitguardian.com/workspace/127396/incidents/11599482?occurrence=161225743) | Triggered | Nx Cloud Token | 03a37fe62f70ad3092b2eb263b640adef2fe143d | nx.json | [View secret](https://github.com/jmcdo29/ogma/commit/03a37fe62f70ad3092b2eb263b640adef2fe143d#diff-15552e50b1b7c05b05b7ffe08ee47b5ed62b8d2039229c58972a42fd22a7381cL50) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/nx_cloud_token#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03a37fe62f70ad3092b2eb263b640adef2fe143d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets - [`nx affected --target=build --parallel=3 --exclude=docs`](https://cloud.nx.app/runs/F8NhrpTJ5D?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/k8Rmhp4ztr?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3`](https://cloud.nx.app/runs/e3w7nFCFDn?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.