refactor: return types in mock functions for strict type checks

jmcdo29 / testing-nestjs

A repository to show off to the community methods of testing NestJS including Unit Tests, Integration Tests, E2E Tests, pipes, filters, interceptors, GraphQL, Mongo, TypeORM, and more!

MIT License

2.88k stars 379 forks source link

refactor: return types in mock functions for strict type checks #1999

Closed neerajkumar161 closed 1 year ago

neerajkumar161 commented 1 year ago

refactored strict types checks in cat.controller.spec.ts in mongo-sample
removed any type annotation in cat.service.ts in mongo-sample

neerajkumar161 commented 1 year ago

Hey collaborators, let me know if this refactor is correct or not. If it is, we can refactor other unit tests as well.

jmcdo29 commented 1 year ago

Nice, tests pass and I think it all looks alright. Feel free to either open a new PR for the others, or modify this one (if modifying this one let me know so I don't merge it too early)

neerajkumar161 commented 1 year ago

@jmcdo29 Awesome 🤩. I will create different PRs for different test files. Is it okay?

jmcdo29 commented 1 year ago

Yeah that works