search

jmcdo29 / testing-nestjs

A repository to show off to the community methods of testing NestJS including Unit Tests, Integration Tests, E2E Tests, pipes, filters, interceptors, GraphQL, Mongo, TypeORM, and more!
MIT License
2.88k stars 379 forks source link

chore: ci node version to 18 and 20 #2003

Closed neerajkumar161 closed 11 months ago

neerajkumar161 commented 12 months ago
neerajkumar161 commented 12 months ago

@jmcdo29 one test case is failing after updating Node.js and pnpm. Can you please take a look?

jmcdo29 commented 12 months ago

Looks like an error with socket.io. I'll have to debug further after some sleep

jmcdo29 commented 11 months ago

Once I have #2005 merged in, this should be fixed and ready to go

jmcdo29 commented 11 months ago

Actually, just realized 2005 will supersede this cause they need to go together. But this PR got me started on the right path of updating the node version so thank you for that!

neerajkumar161 commented 11 months ago

Actually, just realized 2005 will supersede this cause they need to go together. But this PR got me started on the right path of updating the node version so thank you for that!

It's my pleasure. I'm learning many things as well while contributing to the repo. So it's quite fun and challenging for me. :smile:

neerajkumar161 commented 11 months ago

Closing the PR as this is fixed in #2005.