search

jmcerrejon / PiKISS

PiKISS for Raspberry Pi: A bunch of scripts with menu to make your life easier.
http://misapuntesde.com
MIT License
866 stars 90 forks source link

remove unsafe vulkan installation #211

Closed theofficialgman closed 3 months ago

theofficialgman commented 3 months ago

closes https://github.com/jmcerrejon/PiKISS/issues/210 closes https://github.com/jmcerrejon/PiKISS/issues/209

📑 Description

Removes unsafe vulkan installation that overwrites system packages and breaks users installs.

ℹ Additional Information

If the developer wishes to re-add these in a safe manner here is what needs to be done:

  1. install to a path not managed by the package manager (eg: /usr/local). All files can be installed there and are preferred over the main location (eg: /usr/local/bin /usr/local/share /usr/local/vulkan/, etc). Refer to the loader documentation for further explanation https://vulkan.lunarg.com/doc/view/1.3.275.0/linux/loader_and_layer_interface.html
  2. Remove all online components and apt hook (with 1., they are not needed). They are dangerous (prone to fail) and are broken by design (only work if the system is online and the current user running apt/dpkg has the required directory in their $HOME directory, multi-user systems are thus broken)

The developer should add their own cleanup script to fix broken user installs caused by their previous script mistakes. The developer should send a notification to all users (via whatever method available to them) for the affected users. These are not covered in the context of this PR.

jmcerrejon commented 3 months ago

I'll take into account installing the drivers into another directory.

This PR removes the process of installing the latest Vulkan Mesa driver into your OS. I want to let users choose If they want to install it, even If It's not a secure option or you can break it.

Come on, It's Linux! We deserve to break things IF WE WANT!

So I'll reject this PR. Thank you anyway.