support directly scraping from kubelet endpoint

mchtech commented 4 months ago

support directly scraping node metrics from kubelet endpoint in large K8s cluster.

jmcgrath207 commented 4 months ago

Nice! Thanks for your contribution @mchtech. I will have to poke around a bit on my end, but will follow up.

Is there any reason we shouldn't do the anonymous mode as default (aside from breaking continuity for 1.x.x). My guess is the user would have to make some host changes to make this work.

mchtech commented 4 months ago

Nice! Thanks for your contribution @mchtech. I will have to poke around a bit on my end, but will follow up.

Is there any reason we shouldn't do the anonymous mode as default (aside from breaking continuity for 1.x.x). My guess is the user would have to make some host changes to make this work.

anonymous mode relies on kubelet readOnlyPort config.

"automatically listen on readOnlyPort" is disabled by default since k8s v1.2x.
readOnlyPort is a node-level config, and the port is not exposed on node object (unlike "kubelet server port"). The program cannot assume that all kubelet readOnlyPorts are same & use default port in a k8s cluster, unless user/k8s admin specifies it.

jmcgrath207 commented 4 months ago

Thanks for that information, @mchtech. I changed a few things around, but you should be able to use this feature now in 1.10.0

https://github.com/jmcgrath207/k8s-ephemeral-storage-metrics/blob/master/chart/values.yaml#L20

I will look into expanding e2e testing for this configuration later this week.

jmcgrath207 / k8s-ephemeral-storage-metrics

support directly scraping from kubelet endpoint #90