jmcnamara / XlsxWriter

A Python module for creating Excel XLSX files.
https://xlsxwriter.readthedocs.io
BSD 2-Clause "Simplified" License
3.66k stars 632 forks source link

Remove xlsx mention from the xlrd section #1074

Closed xmo-odoo closed 5 months ago

xmo-odoo commented 5 months ago

xlrd removed xlsx support with the 2.0 release (https://xlrd.readthedocs.io/en/latest/changes.html), from 2.0 onwards it only supports the legacy binary file formats.

jmcnamara commented 5 months ago

Thanks for that. The section being updated is intended as a direct quote from the xlrd docs so it should be modified to reflect that.

Or the xlrd section could be dropped altogether. I'll think about that.

xmo-odoo commented 5 months ago

Thanks for that. The section being updated is intended as a direct quote from the xlrd docs so it should be modified to reflect that.

It's pretty much the blurb that's on python-excel:

This package is for reading data and formatting information from older Excel files (ie: .xls)

(I copied the wording from xlwt so that makes sense)

Or the xlrd section could be dropped altogether. I'll think about that.

I think keeping the section makes sense: xlwt is used to write to legacy excel files and xlrd to read from them. So if you're dealing with legacy excel files, you need either or both.

jmcnamara commented 5 months ago

It's pretty much the blurb that's on python-excel

But that isn't the blurb in the link in the docs:

xlrd is a library for reading data and formatting information from Excel files in the historical .xls format.

xmo-odoo commented 5 months ago

Fair enough, there you go.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jmcnamara commented 5 months ago

Merged. Thanks.