search

jmcnamara / libxlsxwriter

A C library for creating Excel XLSX files.
https://libxlsxwriter.github.io
Other
1.49k stars 332 forks source link

Add pkg-config files to the build #322

Closed aymanbagabas closed 3 years ago

aymanbagabas commented 3 years ago

Fixes: https://github.com/jmcnamara/libxlsxwriter/issues/132

This PR adds pkg-config files to Makefile and CMake builds. I know that #132 was closed because the simplicity of linking libxlsxwriter doesn't require pkg-config. However, the reason I'm doing this is that I'm writing a Swift binding to libxlsxwriter and SwiftPM has native support for pkg-config which would make it simpler to build in macOS and Linux. Even though there are other workarounds to this problem, I find using pkg-config the most convenient solution.

jmcnamara commented 3 years ago

Thanks for that. Overall I am in favour of it. I'll make some comments inline.

jmcnamara commented 3 years ago

Thanks. This looks good now. Thanks for bearing with me and making the requested changes.

I have a few more minor comments but it is almost ready for merge.