search

jmcnamara / libxlsxwriter

A C library for creating Excel XLSX files.
https://libxlsxwriter.github.io
Other
1.49k stars 332 forks source link

C++ tests fail with USE_SYSTEM_MINIZIP #358

Closed dotlambda closed 2 years ago

dotlambda commented 2 years ago

After https://github.com/jmcnamara/libxlsxwriter/commit/dd9b1772355f2bae0d31ecda2494f008ce908705, USE_SYSTEM_MINIZIP=1 make test fails with

make[1]: Entering directory '/build/source/test/cpp'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: ../../src/libxlsxwriter.a(packager.o): in function `_add_file_to_zip':
/build/source/src/packager.c:1500: undefined reference to `zipOpenNewFileInZip4_64'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1528: undefined reference to `zipWriteInFileInZip'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1539: undefined reference to `zipCloseFileInZip'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: ../../src/libxlsxwriter.a(packager.o): in function `lxw_packager_new':
/build/source/src/packager.c:114: undefined reference to `zipOpen'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: ../../src/libxlsxwriter.a(packager.o): in function `lxw_create_package':
/build/source/src/packager.c:1604: undefined reference to `zipClose'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1595: undefined reference to `zipClose'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1643: undefined reference to `zipClose'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1655: undefined reference to `zipClose'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: ../../src/libxlsxwriter.a(packager.o): in function `_add_buffer_to_zip':
/build/source/src/packager.c:1554: undefined reference to `zipOpenNewFileInZip4_64'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1568: undefined reference to `zipWriteInFileInZip'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: /build/source/src/packager.c:1576: undefined reference to `zipCloseFileInZip'
/nix/store/ffcrrgb6k5h7crr93dj90bi9fy1jvj16-binutils-2.35.1/bin/ld: ../../src/libxlsxwriter.a(packager.o): in function `lxw_create_package':
/build/source/src/packager.c:1663: undefined reference to `zipClose'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:37: test_compilation] Error 1
make[1]: Leaving directory '/build/source/test/cpp'
make: *** [Makefile:107: test_cpp] Error 2
jmcnamara commented 2 years ago

Fixed in #359. Thanks for the report.