search

jmcnamara / libxlsxwriter

A C library for creating Excel XLSX files.
https://libxlsxwriter.github.io
Other
1.49k stars 332 forks source link

Fix same library names for pods and spm #399

Closed H0xel closed 11 months ago

H0xel commented 1 year ago

Problem When you connect your framework with dependency via pods and inside framework you use spm you have troubles with different import namings

jmcnamara commented 1 year ago

This PR ignores several of the requirements of the https://github.com/jmcnamara/libxlsxwriter/blob/main/CONTRIBUTING.md:

  • Pull requests and new feature proposals must start with an issue tracker. This serves as the focal point for the design discussion.

  • Describe what you plan to do. If there are API changes add some code example to demonstrate them.

  • If your change involves several incremental git commits then rebase or squash them onto another branch so that the Pull Request is a single commit or a small number of logical commits.

I don't use Cocoapod or SPM so I can't evaluate that these patches work or do that they do what they intend to do. Also this appears to change/break the Cocoapod naming. So unless someone else who has worked on Cocoapod/SPM with libxlsxwriter previously steps in to evaluate this PR I won't be able to merge these changes.

jmcnamara commented 11 months ago

I still don't know what issue this PR is fixing, if other people have that issue, or if this is the way to fix it. I haven't received any other bug reports or any +1 for this fix.

So for now I am passing on this PR.