Closed hosiet closed 1 year ago
Thanks. I'll take a look.
There was a "Version/version" typo in the regex that prevented FindMINIZIP.cmake
from reporting the library found even if it was. I fixed that and the compilation works on macOS and Ubuntu 22.04. I want to do a bit more digging to see why this didn't turn up in the past since that code has been there since 2017 (maybe cmake behaviour has changed?).
Anyway, if you get a chance can you test main to see if it works on your OS.
I think I found the reason this didn't fail before. It was due to another change/fix in #398.
Anyway, the good news is that the CI is passing again so I'm going to close this.
We look into what
FindMINIZIP.cmake
does:https://github.com/jmcnamara/libxlsxwriter/blob/f43e53e018b6f90b06e8b7eadb26c30fbfcf0528/cmake/FindMINIZIP.cmake#L92-L95
When enabling
USE_SYSTEM_MINIZIP
and system libminizip is found, these lines basically look through system's/usr/include/zlib.h
and look for strings likeVersion [0-9]+\\.[0-9]+(\\.[0-9]+)?
.However, the
zlib.h
header never had such lines:This condition actually applies to all recent zlib releases.
I believe the logic in
FindMINIZIP.cmake
must be broken somewhere. Can you take a look?