Read overflows causing corruption, and performance issues

[znakeeye]

Please check utility.c. There you find several of these dangerous loops:

while (p && some_operation_here)
    p++;

It should be *p in all cases. E.g. See lxw_name_to_row_2 where parsing "A1" would increment p like 1,000,000 times with some bad luck. Thus, we have a read overflow.

Fix:

1. Replace all if (p) with if (*p)
2. Replace all while (p with while (*p

[jmcnamara]

Thanks for the report. Fixed on main.

[znakeeye]

Thanks. Any plans for an official 1.1.9 release?

[jmcnamara]

If you need one just for this I can do one. Let me know.

[znakeeye]

Yes please. Maintaining local patches is not great 🙂

[jmcnamara]

The changes are upstream in v1.1.9. Thanks.