Feature Request: Ability to switch between regex and regex_lite crates

jmcnamara / rust_xlsxwriter

A Rust library for creating Excel XLSX files.

https://crates.io/crates/rust_xlsxwriter

Apache License 2.0

353 stars 25 forks source link

Feature Request: Ability to switch between regex and regex_lite crates #105

Closed Degubi closed 3 months ago

Degubi commented 3 months ago

Feature Request

The 'regex' crate is huge, and there exists the crate 'regex_lite' that is much smaller & faster to compile, but with the tradeoff of being slower at runtime. Would it be possible to add a feature flag to be able to switch between the 2 dependencies?

jmcnamara commented 3 months ago

Thanks for the suggestion. I'll look into it.

Degubi commented 3 months ago

Hi! I've already implemented locally, running tests atm. Would you take a look? I'll create a pr soon. Have a nice day!

jmcnamara commented 3 months ago

Would you take a look?

Sure. Create a PR and I'll take a look. No rush since I will be offline until the end of the week.

Degubi commented 3 months ago

Opened #106

jmcnamara commented 3 months ago

Closing the feature request as "Can't fix" due to the lack of Unicode support in regex-lite. See the discussion in #106.