search

jmcnamara / rust_xlsxwriter

A Rust library for creating Excel XLSX files.
https://crates.io/crates/rust_xlsxwriter
Apache License 2.0
353 stars 25 forks source link

Remove possible bug concerning "'" in sheet name #43

Closed 2ndDerivative closed 1 year ago

2ndDerivative commented 1 year ago

The excel standard says not to use apostrophes before OR after the sheet name, but this would only trigger if you had them both in your sheet name.

Also strip_suffix/prefix are more idiomatic (and technically protect from panics in non-UTF strings, but that is not relevant here since ' is always one byte)

Belongs to issue #44

jmcnamara commented 1 year ago

Closing the PR since targeted condition isn't a bug (or at least not as reported). See #44.