jmcnevin / rubypants

RubyPants: SmartyPants for Ruby
Other
29 stars 20 forks source link

Allow option to output unicode characters #16

Closed gregfedorov closed 6 years ago

agriffis commented 6 years ago

Great idea! Needs a few tweaks and a test. You might look at https://github.com/jmcnevin/rubypants/pull/15 for a pattern to follow... this should be very similar to how that was added.

gregfedorov commented 6 years ago

I added a quick test and fixed the dash test that was failing earlier, aslo simplified the file structure a bit so that there's no superclass mismatch error anymore.

agriffis commented 6 years ago

Thanks. I'll be able to look closer and merge in a few days

agriffis commented 6 years ago

Thanks Greg. I split this into two changes:

Let me know what you think, and I'll plan to release this as 0.7.0

agriffis commented 6 years ago

@gregfedorov By the way, the email address you're using for commits isn't registered with your github account, so commits don't link properly for you. If you're interested, the setting is at https://github.com/settings/emails

gregfedorov commented 6 years ago

Thanks for the tip! I didn't know commit emails were used for that.