jmcollin78 / versatile_thermostat

A full featured Thermostat for Home Assistant: presets, window, motion, presence and overpowering management
MIT License
328 stars 34 forks source link

expand central configuration #318

Closed maia closed 1 month ago

maia commented 10 months ago

I would like to suggest to move a few configuration aspects to the central configuration:

And by the way, I'm really happy how the central configuration turned out, I think it's a big advantage. Thanks for developing it!

jmcollin78 commented 1 month ago

Hello @maia ,

After considering this proposition it seems that:

  1. cycle can be possible because it is in all vtherm type configuration. In my configuration, I use different cycle to "randomly" dispatch heating and avoid havind allover_switch heater starting at the same time. So that is why cycle is a "personal" VTherm configuration and not a central one. If you do not have aby over_switch VTherm i understand your need,
  2. regulation parameter are not common to all VTherm type: once again, over_switch doesn't have this so It make no sens to put it in common. People that don't have any over_climate will not understand those parameters and think they have an influence on regulation.

So, I will reject this proposal for now but keep on suggesting enhancement please, you have done a great job for VTherm enhancement in the past.

maia commented 1 month ago

Thanks for your kind words. By the way, have you ever considered splitting vtherm into three separate addons (for over_climate, over_valve and over_switch), using a common code base? with the growing functionality it seems it's getting more and more complicated.

jmcollin78 commented 1 month ago

I understand your point but most of feature are multi-vtherm. And most of the work is now done. I just have to maintain, fix the bugs (threre is still !) and add some small missing features.

Having 3 integrations is more hardwork I think. I currenlty have 2 integration to maintains and it is very time consuming (and I have a "real" work in //).