search

jmcooper / angular-hogwarts-tdd-kata

AngularJS TDD Kata
15 stars 9 forks source link

Create Consistent Style for entire project #20

Closed zhon closed 10 years ago

zhon commented 10 years ago

We need a consistent style for the project. For example, I was using single var with different comma styles. While Jim is using Node.js style of multiple vars.

Here is a style guide that helps a bit: http://seravo.fi/2013/javascript-the-winning-style

Another example, two spaces for indentation would give us less horizontal scrolling.

zhon commented 10 years ago

I have fixed the horizontal scrolling.

jmcooper commented 10 years ago

Zhon, did you push the change for horizontal scrolling? It still looks like everything in the readme is using 4 spaces.

jmcooper commented 10 years ago

Also, it looks like you've standardized the comma styles already, right? I found one place and fixed it but looks like you've already done this everywhere.

zhon commented 10 years ago

I fixed the horizontal scrolling by splitting parameters. I like 2 spaces for JS but we are about done.

zhon commented 10 years ago

I hope the comma styles are all the same now. I don't remember if I have fixed the vars to be all the same.

zhon commented 10 years ago

I would like to close this one. If someone does a last run through, I think we can close it.