search

jmcvetta / napping

Golang HTTP client library
286 stars 59 forks source link

Why use Params map instead of just url.Values? #24

Closed cameront closed 9 years ago

cameront commented 9 years ago

I need to set multiple values for a single parameter key, which url values permits since the map value is an array, but napping.Params is a map of string->string.

Would you be opposed to a change making params values an array?

gdm85 commented 9 years ago

I also think it should be URL Values

jmcvetta commented 9 years ago

This seems like a reasonable idea. If you would like to contribute a PR implementing it, I will be happy to accept it.