search

jmcvetta / napping

Golang HTTP client library
286 stars 59 forks source link

allow parameters for HTTP DELETE request #39

Closed skoenig closed 9 years ago

skoenig commented 9 years ago

In order to use the API of our tools with napping, we need the possibility to send parameters with HTTP DELETE requests. This should be compatible with the HTTP standards Therefore, I've extended Delete() function's signature to accept url.Values in the same way like Get() does.

jmcvetta commented 9 years ago

This change seems useful. However it changes the API in a way that is not backwards compatible. So I will accept the PR, and bump the version for napping to v3.0.0 in line with semantic versioning guidelines.

jmcvetta commented 9 years ago

Thanks for contributing!