Closed Delagen closed 7 years ago
@jmdobry please merge it
Thank you for these typings! One suggestion - wouldn't it be better to be declared as a module? import {CacheFactory} from "cachefactory"
would make more sense to me.
@fracz It can be rewritten easy, but for this module must be bundled the same For current it exports directly constructor for commonjs and if you choose es2015 it will be default export ie
import CacheFactory from "cachefactory"
which also not recommended
@fracz made #29 that override this in favour of consistent export @jmdobry consider this when merge
So close #28 in favor of #29?
@jmdobry I agree with both. But in case of consistensy preferred #29 PS. Also please notice that it can broke dependent code.
Closing in favor of #29
For example valid TS code