How come the non minified version has minified code?

shprink commented 10 years ago

https://github.com/jmdobry/angular-cache/blob/master/dist/angular-cache.js#L10

I beleive it is causing problems during my release process. Can you unminified the minified part?

Cheers, Julien

jmdobry commented 10 years ago

@shprink That code is generated by Browserify. How is that code interfering with your release process?

shprink commented 10 years ago

Hi,

As you can see I create a bundle of several angular providers, then I concat them and uglify them. I beleive that uglify has problems minifying your plugin due to the code already minified.

                    , variables.bower + 'angular/angular.js'
                    , variables.bower + 'angular-route/angular-route.js'
                    , variables.bower + 'angular-resource/angular-resource.js'
                    , variables.bower + 'angular-facebook/lib/angular-facebook.js'
                    , variables.bower + 'angular-translate/angular-translate.min.js'
                    , variables.bower + 'angular-translate-loader-static-files/angular-translate-loader-static-files.js'
                    , variables.bower + 'angular-translate-interpolation-messageformat/angular-translate-interpolation-messageformat.js'
                    , variables.bower + 'angular-inview/angular-inview.js'
                    , variables.bower + 'angular-cache/dist/angular-cache.js'
                    , variables.bower + 'angular-moment/angular-moment.js'

shprink commented 10 years ago

I will make further investigation, I just wanted to know if you heard about a similar problem ;)

Cheers

jmdobry commented 10 years ago

There should not be anything in the code generated by Browserify that would cause you problems. However, this could be related to #118

jmdobry / angular-cache

How come the non minified version has minified code? #120