search

jmdobry / angular-cache

angular-cache is a very useful replacement for the Angular 1 $cacheFactory.
http://jmdobry.github.io/angular-cache
MIT License
1.39k stars 156 forks source link

Upgrade grunt browserify #121

Closed shprink closed 10 years ago

shprink commented 10 years ago

Since grunt browserify 2.1.1 https://github.com/jmreidy/grunt-browserify#v211 it "Properly append semicolons to bundle output"

This fixes https://github.com/jmdobry/angular-cache/issues/118 and https://github.com/jmdobry/angular-cache/issues/120

shprink commented 10 years ago

Once you have merged that It would be great if you could re-build and tag a new version. Our product depends on it :)

Thanks very much, Shprink http://julienrenaux.fr/

jmdobry commented 10 years ago

@shprink I'd have taken this pull request, but I needed to fix some other outdated dependencies that were causing issues.

shprink commented 10 years ago

Ok just let me know when everything is up to date, I will personally test the new version.

jmdobry commented 10 years ago

https://github.com/jmdobry/angular-cache/releases/tag/3.1.0

shprink commented 10 years ago

Well done, Cheers ;)

jmdobry commented 10 years ago

Glad to help