4.3 breaks phantomJS tests

jmdobry / angular-cache

angular-cache is a very useful replacement for the Angular 1 $cacheFactory.

http://jmdobry.github.io/angular-cache

MIT License

1.39k stars 156 forks source link

4.3 breaks phantomJS tests #190

Closed rlucha closed 9 years ago

rlucha commented 9 years ago

Updating from 4.2 to 4.3 breaks our karma suite, the following errors appear:

PhantomJS 1.9.8 (Linux 0.0.0) ec-autocomplete-controller encountered a declaration exception FAILED ReferenceError: Can't find variable: Promise Error: [$injector:modulerr] Failed to instantiate module undefined due to: Error: [ng:areq] Argument 'module' is not a function, got undefined

We have switched to ~4.2.0 for now until we can investigate further.

rlucha commented 9 years ago

Fast! thank you

jmdobry commented 9 years ago

No problem, that was my bad, not anticipating others would have PhantomJS tests.