Does not work with Angular 1.3 and browserify

[jukkasi]

I'm using Angular 1.3.20 which is now CommonJS compatible (since 1.3.14).

When I use browserify require('angular-cache') var angular is undefined in your module. This leads to error "angular.module is undefined"

Similar issue has been discussed here https://github.com/likeastore/ngDialog/pull/168 but please note that discussion started BEFORE Angular 1.3.14 and CommonJS changes.

Changing angular-cache.js

if(typeof exports === 'object' && typeof module === 'object') 
    module.exports = factory(require("angular"));

to

if(typeof exports === 'object' && typeof module === 'object')
    module.exports = require("angular");

fixes the issue.

Working example is probably https://github.com/likeastore/ngDialog/blob/master/js/ngDialog.js

[jukkasi]

Any ideas? Would be actually nice to use this library.

Otherwise I'm forced to fork and remove the UMD stuff

[mchambaud]

@jukkasi can you create a pull-request with this fix?

[mchambaud]

Can we get this into angular-cache?!

[SatadruBhattacharjee]

+1

[jmdobry]

Fixed by b491ed83