jmdobry / angular-cache

angular-cache is a very useful replacement for the Angular 1 $cacheFactory.
http://jmdobry.github.io/angular-cache
MIT License
1.39k stars 156 forks source link

feat(deps): upgrade to cachefactory 3.0.0 #258

Open Delagen opened 7 years ago

Delagen commented 7 years ago

Upgrade to latest cachefactory

Main issue with angular is the difference in handling $http promises handling to access headers and other data

before 1.6.x $http().success(data,headers).error(...).then(data)

from 1.6.x $http().then({data,headers...})

Align introduces in 1.4.4 with http://devdocs.io/angularjs~1.5/api/ng/provider/$httpprovider#useLegacyPromiseExtensions

Update: rescan source cause it only sugar. So nothing needed in angular to config. Only https://github.com/jmdobry/CacheFactory/pull/30

Delagen commented 7 years ago

requires https://github.com/jmdobry/CacheFactory/pull/30

jmdobry commented 7 years ago

I guess angular-cache should be update to work with the latest versions of Angular 1.x only?

Delagen commented 7 years ago

I removed unneded config, so it works but only with https://github.com/jmdobry/CacheFactory/pull/30

Where i wrote why.

Delagen commented 7 years ago

Any update?

Delagen commented 7 years ago

Any news?

deini commented 7 years ago

🙏

tocDK commented 6 years ago

Any news regarding this PR?