search

jmdobry / angular-cache

angular-cache is a very useful replacement for the Angular 1 $cacheFactory.
http://jmdobry.github.io/angular-cache
MIT License
1.39k stars 156 forks source link

don't include the version number in the dist files #40

Closed leon closed 11 years ago

leon commented 11 years ago

When using bower and grunt, if I do a bower update angular-cache and it now installed 1.1.0 instead of 1.0.0 it will break my grunt build, since that was using the path bower_components/angular-cache/dist/angular-cache-1.0.0.js

Since bower is the one in charge of versioning I think you can safely leave the version number out of the filename.

jmdobry commented 11 years ago

Yes, Bower follows and expects semver. My tags follow semver and if you look in my bower.json you'll see that "main" points to src/angular-cache.js, which is what you should use when using angular-cache with Bower. Therefore, your path will looks more like bower_components/angular-cache/src/angular-cache.js. While the dist/ folder is mainly for those who don't use Bower, I include the dist/ folder in the Bower package because it has been requested, regardless of the fact that the files in the dist/ folder are versioned.

Cheers.