search

jmdvella / 3dsmax-scripts

My collection of 3dsmax scripts
https://www.jamesvella.net
GNU General Public License v3.0
54 stars 2 forks source link

Error with line 58 when running the script #3

Closed MatMachina closed 2 years ago

MatMachina commented 2 years ago

Hi,

I'm receiving this issue when running the script on Max 2022 and 2023. I have zero coding knowledge, so I have no idea why.

image

And of course, thank you so much for your amazing work!

jmdvella commented 2 years ago

Hi MatMachina,

Line 58 is regarding Opacity. Check if your opacity is a bitmap, if it's just another type of node, remove it or replace it with a bitmap.

However I also notice that it mentions "normal_map". So this could be related to the next line of code which is that the bitmap in the bump slot needs to be a vray normal texture first. So if your normal texture is in the bump slot put it first in the vray normal node eg: [image: image.png]

Let me know if that works and which one it was (opacity or normal).

Cheers, James Vella www.jamesvella.net

On Mon, 8 Aug 2022 at 12:02, MatMachina @.***> wrote:

Hi,

I'm receiving this issue when running the script on Max 2022 and 2023. I have zero coding knowledge, so I have no idea why.

[image: image] https://user-images.githubusercontent.com/110823697/183403350-dbf17ab2-2948-4808-84be-1183aa95dbea.png

And of course, thank you so much for your amazing work!

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3WCZHFBIFJMXQ4ZKDLVYDSMPANCNFSM554WGPGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MatMachina commented 2 years ago

Thanks so much mate! The Normal Map was the culprit.

Unfortunately I'm getting this error now:

image

jmdvella commented 2 years ago

This is because its looking for a DirectX or OpenGL in the normal bitmap filename (Its optional), you can remove these lines of code if that doesnt help your workflow. Ive attached a modified version of the script for you, let me know if it works.

Cheers, James Vella www.jamesvella.net

On Mon, 8 Aug 2022 at 12:55, MatMachina @.***> wrote:

Thanks so much mate! The Normal Map was the culprit.

Unfortunately I'm getting this error now:

[image: image] https://user-images.githubusercontent.com/110823697/183412315-1821a62c-1e67-48e2-9606-ce0e8492fa8f.png

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1208030229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3XQGTZEBNZYPMGPTW3VYDYRTANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

That worked too! Thank you. You're awesome.

Gonna risk really getting on your nerves here but....... :/

image

jmdvella commented 2 years ago

Actually Im glad for the feedback, it lets me know I can add some pop up messages to help users when an error occurs, so thanks!

Seems like the same error, ive just removed it entirely so hopefully that fixes it (attached), if not send me a sample scene and ill see what the problem is.

Cheers, James Vella www.jamesvella.net

On Mon, 8 Aug 2022 at 13:28, MatMachina @.***> wrote:

That worked too! Thank you. You're awesome.

Gonna risk really getting on your nerves here but....... :/

[image: image] https://user-images.githubusercontent.com/110823697/183417868-bf318151-5f63-4db9-b705-dc9fc9da7f06.png

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1208064417, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3S4UTYWTN6TR7UPAGTVYD4QNANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Oh great. In that case I'm glad I can help somewhat.

I'm not seeing your attachment for some reason. Or am I just not looking properly?

jmdvella commented 2 years ago

Check its called modified2

On Mon, Aug 8, 2022, 13:54 MatMachina @.***> wrote:

Oh great. In that case I'm glad I can help somewhat.

I'm not seeing your attachment for some reason. Or am I just not looking properly?

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1208090562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3UT2OHVFRNFXQVIE4DVYD7QHANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

I'm sorry mate, I'm really not seeing it. It is supposed to be attached to your comment just like my screenshots are, right?

jmdvella commented 2 years ago

Yeah,

Ive uploaded it to google drive for you, heres the link https://drive.google.com/file/d/1wQiPL-9KUp00ksMLJqfYx9CX26KE-AsM/view?usp=sharing .

If that error occurs again open the script file from 3dsmax and remove lines 63-67. You can do this by right clicking on the script > Edit Macro Script > Remove the lines > File > save

[image: image.png] [image: image.png]

Cheers, James Vella www.jamesvella.net

On Mon, 8 Aug 2022 at 14:31, MatMachina @.***> wrote:

I'm sorry mate, I'm really not seeing it. It is supposed to be attached to your comment just like my screenshots are, right?

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1208135929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3TCO3DD3VPOHLE7GQLVYED3PANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

You're the best! Thank you so much. Gonna test it tomorrow and get back to you.

jmdvella commented 2 years ago

No worries, let me know if you run into any further issues. 👍

Cheers, James Vella www.jamesvella.net

On Mon, 8 Aug 2022 at 15:02, MatMachina @.***> wrote:

You're the best! Thank you so much. Gonna test it tomorrow and get back to you.

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1208171769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3T6WFF7RBGJ245IP5TVYEHOTANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Worked like bloody charm! 👍 You're a wizard James. Thank you so much. With this script you've made my life so much easier, my boss very happy and made it possible for me to continue to work ...sh*t! ^^

jmdvella commented 2 years ago

Great to hear it Mat! Thanks for the kind words.

I'm hoping to update it in the future to support more textures so if you come across anything you think it needs let me know 👍

On Tue, Aug 9, 2022, 09:03 MatMachina @.***> wrote:

Worked like bloody charm! 👍 You're a wizard James. Thank you so much. With this script you've made my life so much easier, my boss very happy and made it possible for me to continue to work ...sh*t! ^^

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209048552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3WZAY6T4V4FR5G6AB3VYIGGXANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Awesome stuff.

One thing does come to mind, now that I'm test rendering in Blender: transparency (ie glass materials) doesn't seem to transfer to the Principled BSDF. I'm guessing that's cos of the way it's handled by the 2 material types and it's really no biggie to change it manually, but if you did happen to create a solution it'd be sweet.

Thanks again for your work and have a great one mate.

jmdvella commented 2 years ago

Can you show me a screenshot? Both in 3dsmax and then in blender? Mine come in as Principled BRDF when setup in 3dsmax/vray as PBR/Opacity. Is this using Refraction, Translucency etc? Show me the material setup

Cheers, James Vella www.jamesvella.net

On Tue, 9 Aug 2022 at 09:48, MatMachina @.***> wrote:

Awesome stuff.

One thing does come to mind, now that I'm test rendering in Blender: transparency (ie glass materials) doesn't seem to transfer to the Principled BSDF. I'm guessing that's cos of the way it's handled by the 2 material types and it's really no biggie to change it manually, but if you did happen to create a solution it'd be sweet.

Thanks again for your work and have a great one mate.

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209095695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3SUS422V5RHOMEOHP3VYILMTANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Of course. And mine comes in as a Principled BSDF too, just that the transmission does nothing when changed.

This is the VRayMtl before I use your converter: image

This is the material after: image The maps that aren't plugged in, I wasn't planning on using... and now I feel totally stupid, cos i realise that the opacity has no value set due to there being a map for it while it was a VRayMtl and I completely missed that.

However! When I render in Blender, even after changing the transmission, there is no transparency visible in Cycles. Here is the Blender setup: image

jmdvella commented 2 years ago

Great thanks. Which texture do you need in transmission?

Not sure if it's possible using the standard legacy material in 3dsmax but ill see if there is a way.

On Tue, Aug 9, 2022, 10:34 MatMachina @.***> wrote:

Of course. And mine comes in as a Principled BSDF too, just that the transmission does nothing when changed.

This is the VRayMtl before I use your converter: [image: image] https://user-images.githubusercontent.com/110823697/183612483-362826c3-b3a7-4b04-8897-b9e98b290e87.png

This is the material after: [image: image] https://user-images.githubusercontent.com/110823697/183612922-bc6eab39-8a06-46c3-9142-b730916803b2.png The maps that aren't plugged in, I wasn't planning on using... and now I feel totally stupid, cos i realise that the opacity has no value set due to there being a map for it while it was a VRayMtl and I completely missed that.

However! When I render in Blender, even after changing the transmission, there is no transparency visible in Cycles. Here is the Blender setup: [image: image] https://user-images.githubusercontent.com/110823697/183614598-a7630aa3-3415-4079-a1bb-ec6c01977de4.png

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209145477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3X4TTEWLUZJV6GYOFDVYIQ2JANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

That's what I though. Like I said, it's no problem changing it manually, it's only a few clicks.

No texture, just translucency and dirt controlled through either roughness or glossiness.

Thank you again for taking the time and being such a mad lad!

jmdvella commented 2 years ago

Just so i understand, you want the roughness texture plugged into the transmission?

On Tue, Aug 9, 2022, 10:57 MatMachina @.***> wrote:

That's what I though. Like I said, it's no problem changing it manually, it's only a few clicks.

No texture, just translucency and dirt controlled through either roughness or glossiness.

Thank you again for taking the time and being such a mad lad!

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209169844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3S4VT2M4QK3O7VF5JDVYITRPANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Sorry, nah. Transmission is without texture, but the roughness map in the roughness or the glossiness in the specular of the BSDF.

jmdvella commented 2 years ago

Specular should be 0.5 and roughness goes into the roughness slot. Not really sure how you want to adjust transmission, if its a value then it will be done in blender. This script is for converting pbr roughness vray materials. Ior not required either in roughness workflow as it uses metallic (on/off)

On Tue, Aug 9, 2022, 12:06 MatMachina @.***> wrote:

Sorry, nah. Transmission is without texture, but the roughness map in the roughness or the glossiness in the specular of the BSDF.

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209238211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3ULISGBN53K2J3IUIDVYI3ULANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>

MatMachina commented 2 years ago

Got ya. I was thinking that something like that would be the answer. Haven't used blender in quite a few years.

Thanks a lot for the knowledge and time. I really do appreciate it. You've been a huge help!

jmdvella commented 2 years ago

Glad to help.

I don't use blender much myself, but i sell 3D models so i wanted to make sure it was in parity with all apps. I have some scripts fot C4D but i haven't posted them online at this stage.

Thanks for the feedback!

On Tue, Aug 9, 2022, 12:44 MatMachina @.***> wrote:

Got ya. I was thinking that something like that would be the answer. Haven't used blender in quite a few years.

Thanks a lot for the knowledge and time. I really do appreciate it. You've been a huge help!

— Reply to this email directly, view it on GitHub https://github.com/jmdvella/VrayToFBX/issues/3#issuecomment-1209272981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4KW3R73GFDJVO76WA635TVYJAANANCNFSM554WGPGA . You are receiving this because you commented.Message ID: @.***>