search

jmecosta / CxxSonarQubeRunner

GNU Lesser General Public License v3.0
10 stars 6 forks source link

Can't use CxxRunner with nemo.sonarsource.org #54

Closed sawilde closed 8 years ago

sawilde commented 8 years ago

nemo.sonarsource.org uses tokens in the /d:sonar.login and so there is no /d:sonar.password field required however the build runner defaults this to option to admin if not supplied.

Also because the token is also the password we should refrain from dumping this information to the console and treat it as sensitive data.

jmecosta commented 8 years ago

tought i add that thing implemented. i will check. should be easy fix

jmecosta commented 8 years ago

by the way, you should be able to use c++ plugin from nemo. and i far as i saw they do have some wrapper already going on. i havent tried however you might not need this anymore

sawilde commented 8 years ago

:) baby steps

sawilde commented 8 years ago

I've had a go at fixing it by allowing the use of a pseudo switch sonar.token that will set the username to the token and the password to blank and then use a another flag to stop the default password form being added or supplied to the Sonar Build Runner exe

jmecosta commented 8 years ago

looks good, make pr i will merge it. thanks. got myself in the middle of other stuff meanwhile

jmecosta commented 8 years ago

@sawilde after checking this a bit better, i opted to use the /sonar.login=token since its the way the sonar scanner works and visual studio extension (plus there are already 2 many switchs there :)). you can get latest release 1.9.5 and try out. should work

sawilde commented 8 years ago

no worries - I just wanted to spike out a possibility for you as I was not familiar with the code.