search

jmecosta / sonar-fsharp-plugin

F# SonarQube (TM) plugin - support for F#
GNU Lesser General Public License v3.0
52 stars 14 forks source link

remove deprecated apsis #100

Closed jmecosta closed 4 years ago

jmecosta commented 4 years ago

handled #83

milbrandt commented 4 years ago

Should be fine, have you tested the scanner on a SonarQube server? (as initialisation changed) Otherwise I can test it when I'm back in the company.

jmecosta commented 4 years ago

y.

yep i will test later tonight! need to confirm if the java part will not extract the zip everytime it runs

milbrandt commented 4 years ago

y.

yep i will test later tonight! need to confirm if the java part will not extract the zip everytime it runs

Be careful and take care that it will extract every time the version of the plugin changes (up- and downgrade)!

jmecosta commented 4 years ago

good news, is that all is working on my side! bad news is that sonarqube 8.3 with msbuild runner we no longer get f# analysis (on this or master). they must have done something to mess this up... needs more testing! @milbrandt what version are u in... working fine with 7.9 LTS

milbrandt commented 4 years ago

good news, is that all is working on my side! bad news is that sonarqube 8.3 with msbuild runner we no longer get f# analysis (on this or master). they must have done something to mess this up... needs more testing! @milbrandt what version are u in... working fine with 7.9 LTS

We are still on 8.2. In the community forum 8.4 is announced for end of this/beginning of next week - at least a bug releated to IE11 is fixed there :)

Our projects using F# are all in the new Net.Sdk project file format

jmecosta commented 4 years ago

hum, do you mind testing on your side! just to confirm... i really doubt 8.3 would break this... but would be good to confirm this is working in 8.2... net sdk shouldnt be the problem, we are also with those. its more if you are using msbuild sq runner or sonar cli (this ones everything works)

On Wed, Jul 1, 2020 at 6:31 PM Volker Milbrandt notifications@github.com wrote:

good news, is that all is working on my side! bad news is that sonarqube 8.3 with msbuild runner we no longer get f# analysis (on this or master). they must have done something to mess this up... needs more testing! @milbrandt https://github.com/milbrandt what version are u in... working fine with 7.9 LTS

We are still on 8.2. In the community forum 8.4 is announced for end of this/beginning of next week - at least a bug releated to IE11 is fixed there :)

Our projects using F# are all in the new Net.Sdk project file format

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jmecsoftware/sonar-fsharp-plugin/pull/100#issuecomment-652489234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSGAOVSTHOMUT3KOKGLRZNJGRANCNFSM4OMH2QNQ .

milbrandt commented 4 years ago

hum, do you mind testing on your side! just to confirm... i really doubt 8.3 would break this... but would be good to confirm this is working in 8.2... net sdk shouldnt be the problem, we are also with those. its more if you are using msbuild sq runner or sonar cli (this ones everything works)

I did a test with 3.1 (build 376) and one of our F# projects (about 16k lines of F#): the SonarQube tasks worked fine and I got the same number of code smells like before. The bvuild uses Fake, the sonar tasks are in surrounding the yaml pipeline.

jmecosta commented 4 years ago

I suspect u are not using msbuild scanner under fake... this problem will likely appear when u are mixing a project that contains c# and f# which then u are forced to use msbuild scanner

On Thu, 2 Jul 2020, 22:21 Volker Milbrandt, notifications@github.com wrote:

hum, do you mind testing on your side! just to confirm... i really doubt 8.3 would break this... but would be good to confirm this is working in 8.2... net sdk shouldnt be the problem, we are also with those. its more if you are using msbuild sq runner or sonar cli (this ones everything works)

I did a test with 3.1 (build 376) and one of our F# projects (about 16k lines of F#): the SonarQube tasks worked fine and I got the same number of code smells like before. The bvuild uses Fake, the sonar tasks are in surrounding the yaml pipeline.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jmecsoftware/sonar-fsharp-plugin/pull/100#issuecomment-653180709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSGIZNMQSNXDDD5UWULRZTM2BANCNFSM4OMH2QNQ .

jmecosta commented 4 years ago

But anyway this is not a regression from this pull request. But something we. Eed to figure out later. Thanks for confirming

On Fri, 3 Jul 2020, 00:06 Jorge Costa, jmecosta@gmail.com wrote:

I suspect u are not using msbuild scanner under fake... this problem will likely appear when u are mixing a project that contains c# and f# which then u are forced to use msbuild scanner

On Thu, 2 Jul 2020, 22:21 Volker Milbrandt, notifications@github.com wrote:

hum, do you mind testing on your side! just to confirm... i really doubt 8.3 would break this... but would be good to confirm this is working in 8.2... net sdk shouldnt be the problem, we are also with those. its more if you are using msbuild sq runner or sonar cli (this ones everything works)

I did a test with 3.1 (build 376) and one of our F# projects (about 16k lines of F#): the SonarQube tasks worked fine and I got the same number of code smells like before. The bvuild uses Fake, the sonar tasks are in surrounding the yaml pipeline.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jmecsoftware/sonar-fsharp-plugin/pull/100#issuecomment-653180709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSGIZNMQSNXDDD5UWULRZTM2BANCNFSM4OMH2QNQ .