Update to .NET 5.0 - Githubissues

jmecosta / sonar-fsharp-plugin

F# SonarQube (TM) plugin - support for F#

GNU Lesser General Public License v3.0

52 stars 14 forks source link

Update to .NET 5.0 #103

Closed milbrandt closed 3 years ago

milbrandt commented 3 years ago

Prepare for 6-month release for SonarQube

Update to .NET 5.0 in runner, Nuget as multi-targeting library ~=> new major release (SemVer of Nuget package)~
Update of dependencies (maven, .NET test framework)
No upgrade of FSharpLint or F# 5.0, as redundant new issue is still open in Fsharp

TODO:

[x] Test on running SonarQube instance

milbrandt commented 3 years ago

@jmecosta Would bump to new major as Nuget is now net50. Any objections? Tested one build analyses only on SonarQube 8.4.1, but IMHO there is nothing critical.

jmecosta commented 3 years ago

(weird the email reply doenst work). My problem is that you will be forcing me to jump to net50 in the visual studio extension. Im not sure if its even possible since VS is not targeting net50. so maybe the nuget package at least could be kept at netstandard20 would be better for me... for the runtime app, net50 all good for me

milbrandt commented 3 years ago

(weird the email reply doenst work). My problem is that you will be forcing me to jump to net50 in the visual studio extension. Im not sure if its even possible since VS is not targeting net50. so maybe the nuget package at least could be kept at netstandard20 would be better for me... for the runtime app, net50 all good for me

Hi @jmecosta, happy New Year. I'll go to multitarget the Nuget library. Should be ok, even if we will still have the issue of Proj-Info as long as we can't upgrade as redundantant new is still not supporterd again in F# 5.0. As Nuget is no longer breaking, I will not go to new major.

jmecosta commented 3 years ago

Sounds good 👍 happy new year