search

jmecosta / sonar-fsharp-plugin

F# SonarQube (TM) plugin - support for F#
GNU Lesser General Public License v3.0
52 stars 14 forks source link

remove deprecated api #47

Closed jmecosta closed 5 years ago

jmecosta commented 5 years ago

46 replace profile deprecated apis

milbrandt commented 5 years ago

In org.sonar.plugins.fsharp.FSharpSensor there are several other deprecated API used:

jmecosta commented 5 years ago

In org.sonar.plugins.fsharp.FSharpSensor there are several other deprecated API used:

  • CoreMetrics.FILE_COMPLEXITY_DISTRIBUTION
  • CoreMetrics.FUNCTION_COMPLEXITY_DISTRIBUTION
  • org.sonar.api.batch.fs.FileSystem.files

Can habdle that in a new pr.

milbrandt commented 5 years ago

Sonarqube 7.9 LTS is pre-announced for July, thus 8.x will come this year and there the 6.x deprecations will be removed according to their announcements. Are these bigger issues? Why not fix all the 6.x deprecation in this PR so that everything would be ready for Sonarqube 8?

jmecosta commented 5 years ago

Sonarqube 7.9 LTS is pre-announced for July, thus 8.x will come this year and there the 6.x deprecations will be removed according to their announcements. Are these bigger issues? Why not fix all the 6.x deprecation in this PR so that everything would be ready for Sonarqube 8?

time ;) but i pushed the removal in the java side. so SonarQube will be happy. the F# side i still want to keep those one, they might be handy for other stuff

milbrandt commented 5 years ago

time ;) but i pushed the removal in the java side. so SonarQube will be happy. the F# side i still want to keep those one, they might be handy for other stuff

That's a self-evident reason for everyone ;) But IMHO better to fix everything in one release of the plugin. Up to v1.0.5 it's using deprecated API, starting with next release (v1.0.6 maybe) all deprecated API is removed and ready for SonarQube 8.

Seems like you removed alredy 3/4 - I only saw org.sonar.api.batch.fs.FileSystem.files still in the FSharpSensor. (And the merge conflict - this shouldn't be hard and I can support you there).

For me it's fine to leave the F# code in for now.

jmecosta commented 5 years ago

time ;) but i pushed the removal in the java side. so SonarQube will be happy. the F# side i still want to keep those one, they might be handy for other stuff

That's a self-evident reason for everyone ;) But IMHO better to fix everything in one release of the plugin. Up to v1.0.5 it's using deprecated API, starting with next release (v1.0.6 maybe) all deprecated API is removed and ready for SonarQube 8.

Seems like you removed alredy 3/4 - I only saw org.sonar.api.batch.fs.FileSystem.files still in the FSharpSensor. (And the merge conflict - this shouldn't be hard and I can support you there).

For me it's fine to leave the F# code in for now.

uhm, ok i still chekc those

jmecosta commented 5 years ago

should be ok now, if i didnt miss anything

milbrandt commented 5 years ago

In FSharpSensor line 442 and 469 is it correct to set the value 1 or should that be value? This is unchanged in this PR, but Maybe you know it anyway @jmecosta

jmecosta commented 5 years ago

ne 442 and 469

it should be correct, putting more that 1 means one line has more that one comment line. value is the increment of the all file