search

jmecosta / sonar-fsharp-plugin

F# SonarQube (TM) plugin - support for F#
GNU Lesser General Public License v3.0
52 stars 14 forks source link

several rules are showing as deprecated #57

Closed jmecosta closed 5 years ago

jmecosta commented 5 years ago

@milbrandt do u have the same?

image

milbrandt commented 5 years ago

Unfortunately yes, and all rules are marked as major in 1.0.6.122. In 1.0.6.110 there where already the same number of deprecated rules, but with information as severity level.

Maybe there is also a predefined alternative for giving the severity string in each call of activateRule. Otherwise we should introduce an enumeration of strings for the severity levels.

screenshot1-0-6-110

milbrandt commented 5 years ago

released 1.0.5 and even the old 1.0.3 (Oct 2018) have the same behavior as 1.0.6.110

milbrandt commented 5 years ago

org.sonar.api.rule.Severity contails al the supported severity values, see Plugin API

milbrandt commented 5 years ago

In org.sonar.plugins.fsharp.FSharpSonarRulesDefinition, lines 191 ff., the rule names for several rules are set explicitly to deprecated rule. These rules were added on Feb 20, 2018 in commit 3a4847584ae9ae018ee6a8403e59d1b4886c9214

jmecosta commented 5 years ago

ok, so lets remove them since they have been deprecated for a while. i remenber this was done when there was a major refactoring in fsharplint

milbrandt commented 5 years ago

There are several rules in FSharpSonarRulesDefinition which aren't included FSharpSonarWayProfile. Have you deprecated them long ago? I created a branch for some refactoring the above and observed now these additional rules like RulesNamingConventionsTypesError.

jmecosta commented 5 years ago

i think at least more than a year! anwyay, fharp lint will not produce those anymore so we should just remove them.

milbrandt commented 5 years ago

removed in v1.1.0