Rework of rules properties

[milbrandt]

• rules of severity info in 1.0.6.110 reset from Major to info, see issue #57
• use constrants from org.sonar.api.rule.Severity instead of strings
• some refactoring

Open Points:

• [ ] In org.sonar.plugins.fsharp.FSharpSonarRulesDefinition there are 16 additional rules which are not activated in FSharpSonarWayProfile. Some of them should IMHO included, eg RulesRedundantNewKeyword Why are These rules not included? Any history behind it? These rules are unchanged for now.
• [x] RuleProperty - Constructor and getters or a pure bean with getters and setters.
• [x] Missing HtmlDesicription of the rules are in sonar-fsharp-plugin\src\main\resources\org\sonar\l10n\fsharp\rules?
• [x] why set priority in org.sonar.plugins.fsharp.FSharpSonarWayProfile.activateRule as it is already set in FSharpSonarRulesDefinition while creating the rules?

@jmecosta Feel free to commit to this branch on any of the above open points

[milbrandt]

@jmecosta Any comments on my questions in the initial PR? Especially question 1, 3, 4 I don't know the background.

[jmecosta]

The asnwer is pretty much the same, the rules have not ever been stabilized and i supose after of both sonar and fsharp lint those have just become outdated. My sughestion is we take what fsharp lint provides now and go with it. Hrmldescriptiosn i have no idea what to put there, i would rather just not have everything

[milbrandt]

I would like to merge this PR and have created a new issue to sync rules between FshapLint and this plugin.

[jmecosta]

If the current rule set is ok then i dont see why not. Your reporting issue does seem more critical atm

On Thu, 20 Jun 2019, 21:02 Volker Milbrandt, notifications@github.com wrote:

@milbrandt commented on this pull request.

In sonar-fsharp-plugin/src/main/java/org/sonar/plugins/fsharp/FSharpRuleProperties.java https://github.com/jmecsoftware/sonar-fsharp-plugin/pull/61#discussion_r295928825 :

+

• // Typography
• rules.put("RulesTypographyTrailingLineError", new RuleProperty(Severity.MAJOR, "File should not have a trailing new line", "

  "));

• rules.put("RulesTypographyTabCharacterError", new RuleProperty(Severity.MAJOR, "Tabulation character should not be used", "

  "));

• rules.put("RulesTypographyFileLengthError", new RuleProperty(Severity.MAJOR, "File should not have too many lines", "

  "));

• rules.put("RulesTypographyLineLengthError", new RuleProperty(Severity.MAJOR, "Lines should not be too long", "

  "));

• rules.put("RulesTypographyTrailingWhitespaceError", new RuleProperty(Severity.MAJOR, "Lines should not have trailing whitespace", "

  "));

• // nested statements
• rules.put("RulesNestedStatementsError", new RuleProperty(Severity.MAJOR, "Maximum allowed of nesting", "

  "));

• // hint matcher - todo Map of list
• rules.put("RulesHintRefactor", new RuleProperty(Severity.MAJOR, "Hint Refactor", "

  "));

• rules.put("RulesHintSuggestion", new RuleProperty(Severity.MAJOR, "Hint Suggestion", "

  "));

• rules.put("RulesXmlDocumentationExceptionError", new RuleProperty(Severity.INFO, "deprecated rule", "

  "));

I would like to release 1.0.6 officially with net45, removed deprecated API and hopefully my repoting issue (I haven't started looking on it yet). Then the current master would be good for SonarQube 8. All other stuff only in net472 branch, Accord.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jmecsoftware/sonar-fsharp-plugin/pull/61?email_source=notifications&email_token=AAH6HSBHQWMFDQHPTQ76BXDP3PA3LA5CNFSM4HYRSIK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4GASKQ#discussion_r295928825, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH6HSGW4VJZXMDZ4JTMGUDP3PA3LANCNFSM4HYRSIKQ .