Closed ppebb closed 6 months ago
Looks good to me. I'm fine removing the settings comment from the code for now. I'll improve the README soon, and I'll make sure to include possible settings.
For reference, this seems to include the list of settings (see serverOption
)
https://github.com/dotnet/vscode-csharp/blob/main/test/unitTests/configurationMiddleware.test.ts
default values: https://github.com/dotnet/vscode-csharp/blob/main/package.json#L1057-L1251
Allows settings to be passed to roslyn via a settings key in the setup function such as
I did nuke the examples you had commented out, but I was unsure where you would want to put them (readme, wiki?) or where you got them, as the list looked incomplete. I could also add defaults but I do not know what you would want those to be. Feedback would be appreciated so I can add those.